refactor: Use RxJava for VertexAiClient #470
Open
+243
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_812825416
branch
from
e3412a2 to
add677c
Compare
In addition to the refactor, use the built in RxJava sleep functionality instead of Thread.sleep(). Also, adding some randomness to the LRO checking on createSession to test out that the LRO logic works. PiperOrigin-RevId: 812825416
copybara-service
bot
force-pushed
the
test_812825416
branch
from
add677c to
5f4a89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Use RxJava for VertexAiClient
In addition to the refactor, use the built in RxJava sleep functionality instead of Thread.sleep(). Also, adding some randomness to the LRO checking on createSession to test out that the LRO logic works.